Migrate isValid function to TS #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fturmel
reviewed
Jun 23, 2021
src/isValid/index.ts
Outdated
| requiredArgs(1, arguments) | ||
|
|
||
| var date = toDate(dirtyDate) | ||
| return !isNaN(date) | ||
| if (!(dirtyDate instanceof Date) && typeof dirtyDate !== 'number') { |
There was a problem hiding this comment.
I think it would be better to use isDate here since it handles an iframe passing edge case not covered by instanceof alone.
|
@tan75 I think that last change was a mistake. The predicate With predicate, we narrow the result down to Date or number: With boolean return, type is still unknown: |
|
As I pointed out here #2551 (comment), the remaining problem is with the jsdocs / type generator system for these type guards in How to write the jsdocs part: microsoft/TypeScript#25127 (comment) |
tan75
added a commit
to janziemba/date-fns
that referenced
this pull request
Dec 27, 2021
Co-authored-by: Tetiana <ttobin@protonmail.ch> Co-authored-by: Sasha Koss <koss@nocorp.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes date-fns/date-fns-typescriptify#101