convert formatISO to TypeScript
#2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for |
|
@joonmo-you Where is the discrepancy in the docs? |
|
@fturmel Sorry for leading you to misunderstanding what I am tryin to say. I just want to suggest that the examples on the docs deal with the UTC timezone only, which causes my team to be confused with whether |
|
@joonmo-you Oh I see what you're saying. You are right, this could be improved. I'll work on a revision and add it to this PR. |
fturmel
force-pushed
the
PR/ts-formatISO
branch
from
f3893f9
to
a662932
Compare
ghost
approved these changes
Oct 12, 2021
joonmo-you
approved these changes
Oct 22, 2021
tan75
force-pushed
the
PR/ts-formatISO
branch
from
92aba01
to
6f70f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes date-fns/date-fns-typescriptify#37
There's another PR that's almost a year old and wasn't merged (#2098)... I figured it was easy enough to get this done in light of #2592.