Add Spanish locale (closes #268) #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havenchyk
reviewed
Dec 5, 2016
| @@ -4,3 +4,4 @@ tmp | |||
| dist/compressed | |||
| test.espowered.js | |||
| .envrc | |||
| .idea/ | |||
There was a problem hiding this comment.
I'd say you should put this into your global .gitignore instead
There was a problem hiding this comment.
I think this is ok, considering the number of JetBrains users.
dgdavid
reviewed
Dec 5, 2016
| @@ -0,0 +1,84 @@ | |||
| var buildFormattingTokensRegExp = require('../../_lib/build_formatting_tokens_reg_exp/index.js') | |||
|
|
|||
| function buildFormatLocale () { | |||
There was a problem hiding this comment.
Only one thing here: in Spanish, the months, week days and seasons's names normally are written with lower cases.
There was a problem hiding this comment.
OK, I will change it
|
@juanangosto could you please update the list of supported langs as well? https://github.com/date-fns/date-fns/blob/master/docs/i18n.md#supported-languages |
|
👍 |
|
@juanangosto Spanish language locale was released with 1.12.0. (diff: v1.11.2...v1.12.0) Thank you for your awesome contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.