Added Danish language support #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leshakoss
reviewed
Dec 16, 2016
| var weekdaysFull = ['søndag', 'mandag', 'tisdag', 'onsdag', 'torsdag', 'fredag', 'lørdag'] | ||
| var meridiemUppercase = ['AM', 'PM'] | ||
| var meridiemLowercase = ['am', 'pm'] | ||
| var meridiemFull = ['a.m.', 'e.m.'] |
There was a problem hiding this comment.
'e.m.'
@Andersbiha is it a typo?
|
@Andersbiha thank you for your contribution! Please fix failing tests https://travis-ci.org/date-fns/date-fns/builds/184494140#L5775 |
|
Argh - Just realized i'd been pushing from the wrong branch. |
|
I think the locale short name should be changed to DA the ISO 639-2 list states the 2 letter code as DA :) |
|
@Andersbiha thanks again for contribution! 🇩🇰 Danish locale was released with 1.21.0 (diff: v1.20.1...v1.21.0) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Danish language support.
Since AM, PM and ordinal number notation isn't used in Danish i kept the defaults.