New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isDate
#471
Remove isDate
#471
Conversation
8e5ef87
to
701e0de
Compare
701e0de
to
e237b10
Compare
Sorry to comment on this old pull request, but why was this functionality removed? typeof date === 'object' && Object.prototype.toString.call(date) === '[object Date]' See lodash implementation (which seems to have a performance optimisation for Node.js): https://github.com/lodash/lodash/blob/master/isDate.js I see no reason why this function shouldn't be provided by date-fns. |
Just adding that a proper implementation of Just leaving my two cents here. |
@nunocastromartins this is a very good point. @leshakoss WDYT? |
No description provided.