Udpate French locale to match the new V2 API #778
Conversation
| @@ -1,5 +1,42 @@ | |||
| import buildFormatLongFn from '../../../_lib/buildFormatLongFn/index.js' | |||
There was a problem hiding this comment.
Please fix the code style issues: https://travis-ci.org/date-fns/date-fns/jobs/391123642#L487
/home/travis/build/date-fns/date-fns/src/locale/fr/_lib/formatLong/index.js
40:5 error 'formatLong' is already defined no-redeclare
/home/travis/build/date-fns/date-fns/src/locale/fr/_lib/localize/index.js
74:1 error Expected indentation of 4 spaces but found 6 indent
/home/travis/build/date-fns/date-fns/src/locale/fr/_lib/match/index.js
15:1 error More than 1 blank line not allowed no-multiple-empty-lines
50:25 error Unnecessary escape character: \' no-useless-escape
/home/travis/build/date-fns/date-fns/src/locale/fr/test.js
48:35 error Strings must use singlequote quotes
80:27 error Strings must use singlequote quotes
122:1 error More than 1 blank line not allowed no-multiple-empty-lines
src/locale/fr/test.js
Outdated
| // assert(result === '10h, 10h, 10h') | ||
| // }) | ||
|
|
||
| // removed the 3rd assertion, AFAIK there are no narrow versions of midnight in French |
There was a problem hiding this comment.
Please return the third assertion back but let's use the same minuit for it. See: https://www.unicode.org/cldr/charts/32/summary/fr.html#1962
src/locale/fr/test.js
Outdated
| }) | ||
|
|
||
| // France is using a 24h day, there are no AM PM notions | ||
| // it('AM, PM', function () { |
There was a problem hiding this comment.
Let's reenable the test. Even if France doesn't use the AM/PM, format, we still should add it for consistency. Using just AM and PM is OK: https://www.unicode.org/cldr/charts/32/summary/fr.html#1928
src/locale/fr/test.js
Outdated
| // France is using a 24h day, there are no AM PM notions | ||
| // it('AM, PM', function () { | ||
| // var result = format(date, 'h a, h aaaa, haaaaa', {locale: locale}) | ||
| // assert(result === '10h, 10h, 10h') |
There was a problem hiding this comment.
Please, instead of commenting out some tests, use it.skip, so the testing utility will clearly show what functionality is yet to be implemented
|
Thanks for the review ! Oh lord this made me realise I kind of commited some garbage files, sorry for that ! :) I looked into the AM / PM some more in French language and it appears that the rules state that we use it if necessary and always capitalise it so I reflected that in the last commit (as seen here in the unicode chart) Test is now un commented, same for 'minuit' which should be use in all cases. Hope this helps up move forward a bit more ! |
|
Managed to narrow it down to the test errors that I can't understand where the and the parsing tests which I have to work on because my regex game is weak. |
| today: '[aujourd’hui à] LT', | ||
| tomorrow: '[demain à] LT', | ||
| nextWeek: 'dddd [à] LT', | ||
| lastWeek: "dddd 'dernier à' LT", |
There was a problem hiding this comment.
Please use eeee instead of dddd; p instead of LT; P instead of L. Those are the format tokens: https://date-fns.org/v2.0.0-alpha.10/docs/format we've changed them in 8th alpha
|
@Lakston I fixed some of the tests (see the last commit in your branch). Could you please verify that my changes make sense in French? Thanks |
|
I started doing that yesterday :) I'll have some modifications but I'll make another PR probably because I have some questions to ask first, I'll post those in the related issue. |
|
The locale is released as |
There are some problems with the tests and I'm bad at regex so I'll have to work more on those.
edit: forgot to mention the associated issue: #777