-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'ETS' (community contribution) #1792
Add 'ETS' (community contribution) #1792
Conversation
5fd7254
to
f27e7ae
Compare
"runs": [ | ||
"TOEFL" | ||
], | ||
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address
(1077 XX Amsterdam – The Netherlands
) is not a country.
We've decided on specific variations for these countries:
United States of America
The Netherlands
Republic of Singapore
"runs": [ | ||
"TOEFL" | ||
], | ||
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name
in the address
.
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands", | |
"address": "U.S. Mail:\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands", |
{ | ||
"type": "email" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /required-elements/0 is missing the required field 'desc'.”
Raw error:
{
"path": "$.required-elements[0]",
"pointer": "/required-elements/0",
"message": "The value at /required-elements/0 is missing the required field 'desc'.",
"data": {
"type": "email"
}
}
{ | ||
"type": "name" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /required-elements/1 is missing the required field 'desc'.”
Raw error:
{
"path": "$.required-elements[1]",
"pointer": "/required-elements/1",
"message": "The value at /required-elements/1 is missing the required field 'desc'.",
"data": {
"type": "name"
}
}
{ | ||
"type": "birthdate" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /required-elements/2 is missing the required field 'desc'.”
Raw error:
{
"path": "$.required-elements[2]",
"pointer": "/required-elements/2",
"message": "The value at /required-elements/2 is missing the required field 'desc'.",
"data": {
"type": "birthdate"
}
}
"runs": [ | ||
"TOEFL" | ||
], | ||
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [recordlint] <trim-address-lines> reported by reviewdog 🐶
The lines of the address
aren't trimmed (at least one line contains trailing or leading whitespace).
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands", | |
"address": "U.S. Mail:\nETS\n660 Rosedale Road\nPrinceton, NJ 08541 USA\nEU Mail:\nETS Global B.V.\nAcademic & Business Assessments\nStrawinskylaan 929\n1077 XX Amsterdam – The Netherlands", |
Superseded by #1807. |
This suggestion was submitted through the website.
Edit in company JSON generator