Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'ETS' (community contribution) #1792

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"runs": [
"TOEFL"
],
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (1077 XX Amsterdam – The Netherlands) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

"runs": [
"TOEFL"
],
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <name-in-address> reported by reviewdog 🐶
Record includes name in the address.

Suggested change
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands",
"address": "U.S. Mail:\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands",

Comment on lines +21 to +23
{
"type": "email"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /required-elements/0 is missing the required field 'desc'.”

Raw error:

{
    "path": "$.required-elements[0]",
    "pointer": "/required-elements/0",
    "message": "The value at /required-elements/0 is missing the required field 'desc'.",
    "data": {
        "type": "email"
    }
}

Comment on lines +24 to +26
{
"type": "name"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /required-elements/1 is missing the required field 'desc'.”

Raw error:

{
    "path": "$.required-elements[1]",
    "pointer": "/required-elements/1",
    "message": "The value at /required-elements/1 is missing the required field 'desc'.",
    "data": {
        "type": "name"
    }
}

Comment on lines +27 to +29
{
"type": "birthdate"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /required-elements/2 is missing the required field 'desc'.”

Raw error:

{
    "path": "$.required-elements[2]",
    "pointer": "/required-elements/2",
    "message": "The value at /required-elements/2 is missing the required field 'desc'.",
    "data": {
        "type": "birthdate"
    }
}

"runs": [
"TOEFL"
],
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <trim-address-lines> reported by reviewdog 🐶
The lines of the address aren't trimmed (at least one line contains trailing or leading whitespace).

Suggested change
"address": "U.S. Mail:\n ETS\n 660 Rosedale Road\n Princeton, NJ 08541 USA\nEU Mail:\n ETS Global B.V.\n Academic & Business Assessments\n Strawinskylaan 929\n 1077 XX Amsterdam – The Netherlands",
"address": "U.S. Mail:\nETS\n660 Rosedale Road\nPrinceton, NJ 08541 USA\nEU Mail:\nETS Global B.V.\nAcademic & Business Assessments\nStrawinskylaan 929\n1077 XX Amsterdam – The Netherlands",

@baltpeter baltpeter added the duplicate This issue or pull request already exists label Sep 22, 2023
@baltpeter
Copy link
Member

Superseded by #1807.

@baltpeter baltpeter closed this Sep 22, 2023
@baltpeter baltpeter deleted the suggest_ets_1656184411990 branch September 22, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants