Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Brand Markt' (community contribution) #1961

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"all"
],
"name": "Brand Markt",
"address": "Rosenbergstrasse 46, 9000 St.Gallen",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <address-newlines> reported by reviewdog 🐶
Lines of the address are not separated by newlines (\n).

Suggested change
"address": "Rosenbergstrasse 46, 9000 St.Gallen",
"address": "Rosenbergstrasse 46\n9000 St.Gallen",

"all"
],
"name": "Brand Markt",
"address": "Rosenbergstrasse 46, 9000 St.Gallen",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Rosenbergstrasse 46, 9000 St.Gallen) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore

],
"name": "Brand Markt",
"address": "Rosenbergstrasse 46, 9000 St.Gallen",
"phone": "041797738712",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "041797738712"
}

@fm
Copy link
Collaborator

fm commented Nov 30, 2022

Duplicate of #1962

@fm fm marked this as a duplicate of #1962 Nov 30, 2022
@fm fm closed this Nov 30, 2022
@mal-tee mal-tee deleted the suggest_brand-markt_1669789868102 branch November 30, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants