Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Italia Loyalty S.p.A.' (community contribution) #2490

Conversation

datenanfragen-community-edits
Copy link
Collaborator

This suggestion was submitted through the website.

Edit in company JSON generator

"runs": [
"MilleMiglia"
],
"address": "Piazza Almerico da Schio, 3\nPalazzina BRAVO, secondo piano\n00054 Fiumicino (RM)\nRome Italy",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <end-address-in-country> reported by reviewdog 🐶
Last line of address (Rome Italy) is not a country.

We've decided on specific variations for these countries:

  • United States of America
  • The Netherlands
  • Republic of Singapore
Suggested change
"address": "Piazza Almerico da Schio, 3\nPalazzina BRAVO, secondo piano\n00054 Fiumicino (RM)\nRome Italy",
"address": "Piazza Almerico da Schio, 3\nPalazzina BRAVO, secondo piano\n00054 Fiumicino (RM)\nRome Italy\nUnited States of America",

"MilleMiglia"
],
"address": "Piazza Almerico da Schio, 3\nPalazzina BRAVO, secondo piano\n00054 Fiumicino (RM)\nRome Italy",
"phone": "0039 06 65645",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [recordlint] <pass-schema> reported by reviewdog 🐶
Record did not pass schema validation: “The value at /phone is an invalid string.”

Raw error:

{
    "path": "$.phone",
    "pointer": "/phone",
    "message": "The value at /phone is an invalid string.",
    "data": "0039 06 65645"
}

@baltpeter baltpeter enabled auto-merge (squash) April 30, 2024 08:01
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit f04bbce into datenanfragen:master Apr 30, 2024
1 of 2 checks passed
@baltpeter baltpeter deleted the suggest_mymiglia_1703781152432 branch April 30, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
record Issue related to the JSON records via-suggest-api
Development

Successfully merging this pull request may close these issues.

None yet

3 participants