Fixes #148: French translation #161
Conversation
Currently translated at 98.9% (631 of 638 strings) Translation: Datenanfragen.de/website Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/fr/
Currently translated at 98.9% (631 of 638 strings) Translation: Datenanfragen.de/website Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/fr/
Currently translated at 100.0% (638 of 638 strings) Translation: Datenanfragen.de/website Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/fr/
baltpeter
changed the title
…/website into b_french
baltpeter
changed the title
|
@NathanBnm Done. Huge thanks once again! @zner0L This should now be ready for review. |
That was… surprisingly not bad. Go figure, I 'spose. Note: This will *hopefully* result in a merge conflict with #161, as that moves the requests.json file into the other translations.
| // Since we now support languages where we cannot guarantee that all strings are always translated, we now need to | ||
| // fallback to English for untranslated strings. | ||
| const en = require('../i18n/en.json'); | ||
| data = deepmerge(en, data); |
There was a problem hiding this comment.
I would like to at least see what translations are missing in debug env. Or are we just going to let Weblate do the work there?
There was a problem hiding this comment.
I agree with the sentiment but I don't see how to implement this in a way that improves on the current implementation:
- The only languages for which we can guarantee support are German and English anyway.
- Seeing an English string on the German site should be pretty obvious anyway.
- The previous implementation didn't actually alert or highlight missing translations either. It just left them blank. I feel like that is even easier to miss than a translation in the wrong language.
- What would we change the strings to in the dev env to indicate missing translations? We can't use HTML to actually make them stand out.
- Weblate makes missing translations pretty obvious.
| * In the deploy script `deploy.sh`, make sure to also copy the companies and SVAs for the new language. | ||
| * Add the new language to the `languageFiles` for `preact-i18n` in `.eslintrc.js`. | ||
| * In `content/` create a `*.[new lang].md` file for all pages that should be available in the new language. | ||
| * Specify the menu items in `config/_default/menus.toml`. That file is unfortunately not part of the Weblate infrastructure. |
There was a problem hiding this comment.
Is there a way to still add the necessary translations to the files nevertheless? I mean, for French it might be possible to do it ourselves but for any other language we need those strings translated as well.
There was a problem hiding this comment.
I absolutely agree.
Unfortunately, I don't believe that is possible in Hugo. So our options are:
- Either write our own preprocessor for those files, or
- Hardcode the menus in the Hugo
baseof.htmltemplate.
There was a problem hiding this comment.
I was just thinking of having the translations in the translation file and copying those by hand. That leaves some work to us, but we don't need to translate them.
There was a problem hiding this comment.
@baltpeter I don't know if we need to solve this here though. Merge if you like.
There was a problem hiding this comment.
Well, I guess that would work, too… Now that we are having our own Webpack thingies anyway, writing a preprocessor might not even be that hard, though.
Let's see. Does GitHub also have a 'Resolve as an issue' button?
|
@zner0L ? |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Thanks to @NathanBnm, we have a French translation of the website (see #148). This PR will actually expose that in the UI.