Skip to content

Commit

Permalink
Merge pull request #755 from lucaferocino/master
Browse files Browse the repository at this point in the history
Improved docstrings for count and until parameters
  • Loading branch information
pganssle committed Jun 8, 2018
2 parents 94cfe1e + b968c0c commit 10e23cc
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
1 change: 1 addition & 0 deletions AUTHORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ switch, and thus all their contributions are dual-licensed.
- Kubilay Kocak <koobs@MASKED>
- Laszlo Kiss Kollar <kiss.kollar.laszlo@MASKED> (gh: @lkollar) **D**
- Lauren Oldja <oldja@MASKED> (gh: @loldja)
- Luca Ferocino <luca.ferox@MASKED> (gh: @lucaferocino)
- Mario Corchero <mcorcherojim@MASKED> (gh: @mariocj89) **R**
- Mateusz Dziedzic (gh: @m-dz) **D**
- Matthew Schinckel <matt@MASKED>
Expand Down
2 changes: 2 additions & 0 deletions changelog.d/755.doc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improved documentation on the use of ``until`` and ``count`` parameters in ``rrule``.
Fixed by @lucaferocino (gh pr #755).
18 changes: 12 additions & 6 deletions dateutil/rrule.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,20 +353,26 @@ class rrule(rrulebase):
from calendar.firstweekday(), and may be modified by
calendar.setfirstweekday().
:param count:
How many occurrences will be generated.
If given, this determines how many occurrences will be generated.
.. note::
As of version 2.5.0, the use of the ``until`` keyword together
with the ``count`` keyword is deprecated per RFC-5545 Sec. 3.3.10.
As of version 2.5.0, the use of the keyword ``until`` in conjunction
with ``count`` is deprecated, to make sure ``dateutil`` is fully
compliant with `RFC-5545 Sec. 3.3.10 <https://tools.ietf.org/
html/rfc5545#section-3.3.10>`_. Therefore, ``until`` and ``count``
**must not** occur in the same call to ``rrule``.
:param until:
If given, this must be a datetime instance, that will specify the
If given, this must be a datetime instance specifying the upper-bound
limit of the recurrence. The last recurrence in the rule is the greatest
datetime that is less than or equal to the value specified in the
``until`` parameter.
.. note::
As of version 2.5.0, the use of the ``until`` keyword together
with the ``count`` keyword is deprecated per RFC-5545 Sec. 3.3.10.
As of version 2.5.0, the use of the keyword ``until`` in conjunction
with ``count`` is deprecated, to make sure ``dateutil`` is fully
compliant with `RFC-5545 Sec. 3.3.10 <https://tools.ietf.org/
html/rfc5545#section-3.3.10>`_. Therefore, ``until`` and ``count``
**must not** occur in the same call to ``rrule``.
:param bysetpos:
If given, it must be either an integer, or a sequence of integers,
positive or negative. Each given integer will specify an occurrence
Expand Down

0 comments on commit 10e23cc

Please sign in to comment.