Merge pull request #721 from pganssle/comma_sep

Comma separator for ISO 8601 parser
dateutil · May 16, 2018 · 4ec670d · 4ec670d
2 parents ad98073 + 86c8f5b
commit 4ec670d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/changelog.d/721.bugfix.rst b/changelog.d/721.bugfix.rst
@@ -0,0 +1 @@
+Add support for ISO 8601 times with comma as the decimal separator. (gh pr #721)
diff --git a/dateutil/parser/isoparser.py b/dateutil/parser/isoparser.py
@@ -91,7 +91,9 @@ def isoparse(self, dt_str):
         - ``hh:mm:ss.sss`` or ``hh:mm:ss.ssssss`` (3-6 sub-second digits)
 
         Midnight is a special case for `hh`, as the standard supports both
-        00:00 and 24:00 as a representation.
+        00:00 and 24:00 as a representation. The decimal separator can be
+        either a dot or a comma.
+
 
         .. caution::
 
@@ -193,7 +195,7 @@ def parse_tzstr(self, tzstr, zero_as_utc=True):
     _MICROSECOND_END_REGEX = re.compile(b'[-+Z]+')
     _DATE_SEP = b'-'
     _TIME_SEP = b':'
-    _MICRO_SEP = b'.'
+    _MICRO_SEPS = b'.,'
 
     def _parse_isodate(self, dt_str):
         try:
@@ -349,7 +351,7 @@ def _parse_isotime(self, timestr):
 
             if comp == 3:
                 # Microsecond
-                if timestr[pos:pos + 1] != self._MICRO_SEP:
+                if timestr[pos:pos + 1] not in self._MICRO_SEPS:
                     continue
 
                 pos += 1

diff --git a/dateutil/test/test_isoparser.py b/dateutil/test/test_isoparser.py
@@ -120,7 +120,8 @@ def test_ymd_hms(dt, date_fmt, time_fmt, tzoffset):
 DATETIMES = [datetime(2017, 11, 27, 6, 14, 30, 123456)]
 @pytest.mark.parametrize('dt', tuple(DATETIMES))
 @pytest.mark.parametrize('date_fmt', YMD_FMTS)
-@pytest.mark.parametrize('time_fmt', (x + '.%f' for x in HMS_FMTS))
+@pytest.mark.parametrize('time_fmt', (x + sep + '%f' for x in HMS_FMTS
+                                      for sep in '.,'))
 @pytest.mark.parametrize('tzoffset', TZOFFSETS)
 @pytest.mark.parametrize('precision', list(range(3, 7)))
 def test_ymd_hms_micro(dt, date_fmt, time_fmt, tzoffset, precision):