Use "fat" zic binaries in CI tests #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
changed the title
pganssle
force-pushed
the
no_slim
branch
3 times, most recently
from
d16a92e
to
f411724
Compare
pganssle
changed the title
pganssle
force-pushed
the
no_slim
branch
3 times, most recently
from
b7c6f48
to
f717a02
Compare
At the moment, we do not support Version 2 files (see dateutilGH-590), and many zones will be inaccurate *today* when dateutil.tz is used with a slim binary. For the moment, we'll force fat binaries. In the long term, we'll migrate to something like zoneinfo.
This should be reverted when support for version 2+ TZif files is added (see dateutilGH-1059).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The CI failures are basically manifestations of #1059 (which can be resolved along with #590 when we backport the logic from
zoneinfo).I don't want this to continue blocking things and it's a known issue, so I've changed the test to always use the "fat" binaries until #590 is resolved.
Pull Request Checklist