-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Move to python-build
#1133
Conversation
What was expected to be easy is not, for some weird reason |
@@ -5,5 +5,5 @@ freezegun ; python_version != '3.3' | |||
hypothesis >= 3.30 | |||
coverage | |||
mock ; python_version < '3.0' | |||
pep517 >= 0.5.0 | |||
build >= 0.3.0 ; python_version >= '3.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need the python version qualifier here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This runs on Python 3.3, which is not supported by python-build I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh 😊 technically virtualenv also does not support that xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a changelog entry for this one, since it might cause changes to the output wheels for some unknown reason (though admittedly at this point the "misc" section is omitted from the actual changelog, I'm wondering if we may want to change that before the next release.
PEP517 is deprecated, move to `python-build`. This will additionally validate the build dependencies, enhancing the CI.
PEP517 is deprecated, move to
python-build
. This will additionallyvalidate the build dependencies, enhancing the CI.
Summary of changes
Closes
Pull Request Checklist