Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Move to python-build #1133

Merged
merged 1 commit into from May 21, 2021
Merged

Conversation

mariocj89
Copy link
Member

@mariocj89 mariocj89 commented May 21, 2021

PEP517 is deprecated, move to python-build. This will additionally
validate the build dependencies, enhancing the CI.

Summary of changes

Closes

Pull Request Checklist

  • Changes have tests
  • Authors have been added to AUTHORS.md
  • News fragment added in changelog.d. See CONTRIBUTING.md for details

@mariocj89 mariocj89 requested review from pganssle and ffe4 May 21, 2021 11:24
@mariocj89 mariocj89 self-assigned this May 21, 2021
@mariocj89
Copy link
Member Author

What was expected to be easy is not, for some weird reason python-build seems not to work properly within tox. It does work fin within a venv and virtualenv though. I'll look into this once I come back from holidays, unless @gaborbernat knows something about this already :P.

@@ -5,5 +5,5 @@ freezegun ; python_version != '3.3'
hypothesis >= 3.30
coverage
mock ; python_version < '3.0'
pep517 >= 0.5.0
build >= 0.3.0 ; python_version >= '3.6'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the python version qualifier here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs on Python 3.3, which is not supported by python-build I believe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh 😊 technically virtualenv also does not support that xD

Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a changelog entry for this one, since it might cause changes to the output wheels for some unknown reason (though admittedly at this point the "misc" section is omitted from the actual changelog, I'm wondering if we may want to change that before the next release.

PEP517 is deprecated, move to `python-build`. This will additionally
validate the build dependencies, enhancing the CI.
@mariocj89 mariocj89 merged commit 77fb133 into dateutil:master May 21, 2021
@mariocj89 mariocj89 deleted the pu/pybuild branch May 21, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants