Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing __slots__ in parser._parser._resultbase #1186

Open
ariebovenberg opened this issue Jan 21, 2022 · 0 comments · May be fixed by #1187
Open

Missing __slots__ in parser._parser._resultbase #1186

ariebovenberg opened this issue Jan 21, 2022 · 0 comments · May be fixed by #1187

Comments

@ariebovenberg
Copy link

Both _tzparser._result and parser._result have slots and inherit from _resultbase, which does not have slots. This reduces the memory savings from __slots__, and doesn't prevent __dict__ from being created.

solution: add __slots__ to parser._parser._resultbase

I will create a PR shortly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add empty slots to _resultbase, whose subclasses have slots ariebovenberg/dateutil
1 participant
@ariebovenberg