Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tzstr not properly detecting invalid strings #259

Closed
pganssle opened this issue Apr 25, 2016 · 1 comment · Fixed by #581
Closed

tzstr not properly detecting invalid strings #259

pganssle opened this issue Apr 25, 2016 · 1 comment · Fixed by #581

Comments

@pganssle
Copy link
Member

pganssle commented Apr 25, 2016

I noticed that this test is not actually parsing the time zone string correctly because that string format is not supported:

>>> from dateutil import tz
>>> tz.tzstr("EST5EDT") == tz.tzstr("EST5EDT,4,1,0,7200,10,-1,0,7200,3600")
True
>>> tz.tzstr("EST5EDT") == tz.tzstr("EST5EDT,5,4,0,7200,11,-3,0,7200,3600")
True

I'm thinking maybe once this is fixed, these tests should be switched to compare tzstr to tzrange, or to some performance-based tests (like checking that the transitions happen at the right time, etc.

@pganssle pganssle added this to the 2.6.0 milestone Apr 25, 2016
@pganssle
Copy link
Member Author

pganssle commented Nov 6, 2016

Putting this off for the first bugfix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant