-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Easter typos #1026
Fix Easter typos #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugovk Can you rebase against master? I merged a PR adding GHA like the same minute you opened this PR.
That's the old look: https://dateutil.readthedocs.io/en/stable/easter.html The new look will be more like: |
Sorry, I did just quickly copy-paste your code instead of pulling it via git and made a mistake. Your screenshot is correct. |
@ffe4 I think it might be a coincidence that the numbering happens to match the values. We could maybe rearrange things to use non-numbered bullets, or to have non-numbered bullet points that mention the constant directly, but for the purposes of this minor PR we can keep it as is and just fix the numbering. |
Appveyor status reporting is currently not working and there appears to be very little I can do about it, but the actual build is passing so I'm going to go ahead and merge. I guess we can skip the news on this as it's pretty trivial. |
Summary of changes
Easter is a proper noun.
Fixes https://dateutil.readthedocs.io/en/stable/easter.html
Pull Request Checklist