Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to src layout #1146

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Move to src layout #1146

merged 2 commits into from
Aug 9, 2021

Conversation

mariocj89
Copy link
Member

Move the project to the src layout to ensure we are testing on the
generated package rather than the checked out source tree.

Summary of changes

Closes

Pull Request Checklist

  • Changes have tests
  • Authors have been added to AUTHORS.md
  • News fragment added in changelog.d. See CONTRIBUTING.md for details

@mariocj89 mariocj89 self-assigned this Jul 16, 2021
@mariocj89 mariocj89 marked this pull request as draft July 16, 2021 09:22
@mariocj89 mariocj89 changed the title wip: Move to src layout Move to src layout Jul 16, 2021
@mariocj89 mariocj89 force-pushed the pu/src branch 8 times, most recently from 191835a to 1c72b29 Compare July 16, 2021 11:11
MANIFEST.in Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
src/dateutil/_version.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
updatezinfo.py Show resolved Hide resolved
Move the project to the src layout to ensure we are testing on the
generated package rather than the checked out source tree.
Move tests folder to the top of the source checkout and remove it from
the package. We are still including the tests in the sdist in case
downstream package managers want to test out their packaging.
@mariocj89
Copy link
Member Author

@pganssle this should be ready now.

@mariocj89 mariocj89 marked this pull request as ready for review July 23, 2021 12:47
@mariocj89 mariocj89 merged commit 0cc33ad into dateutil:master Aug 9, 2021
@mariocj89 mariocj89 deleted the pu/src branch August 9, 2021 15:45
@pganssle
Copy link
Member

pganssle commented Aug 9, 2021

@hroncok FYI, we've changed the layout which may change how tests and such are run.

@imomaliev
Copy link

This is probably been taken into account but I thought I would still mention it. After git mv history in github is not preserved. May I suggest tagging latest non-src commit for cases when git blame is required?

@mariocj89
Copy link
Member Author

After git mv history in github is not preserved.

I usually just go to the parent commit. Also note that github is smart enough to show you the relevant change in the file, see https://github.com/dateutil/dateutil/blame/master/src/dateutil/__init__.py.

There is also a tag for the prev version, that can be used for that purposed as well.

@kloczek
Copy link

kloczek commented Mar 11, 2022

Is it possible to make new release with that commit? 🤔

@mariocj89
Copy link
Member Author

We are waiting for #1130 to cut a release. Once we land a PR we will immediately cut it. @pganssle has been quite busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants