Changed internal rrule._byxxx variables back to tuples (now sorted). #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…They are still sets first, so duplicate input values are discarded.
pganssle
added a commit
that referenced
this pull request
Mar 5, 2015
Changed internal rrule._byxxx variables back to tuples (now sorted).
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Mar 5, 2015
aschatten
pushed a commit
to aschatten/dateutil
that referenced
this pull request
Nov 16, 2015
Changed internal rrule._byxxx variables back to tuples (now sorted).
aschatten
pushed a commit
to aschatten/dateutil
that referenced
this pull request
Nov 16, 2015
mgeubelle
added a commit
to odoo-dev/odoo
that referenced
this pull request
Oct 28, 2016
Depending on the version of dateutil, rule._bynweekday can either be a tuple or a set (see dateutil/dateutil#54), which, in the case of a set, breaks the access by index (see related issue: dateutil/dateutil#24). By casting it into a list, we make sure that we can access [0] in both case. Credits to jke ; closes opw-690761.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided that at least for now, it's best not to keep these as sets. Although we're under no particular API obligations to maintain the data types of internal variables, I don't think the speedup is particularly dramatic, and I know there's code out there relying on the fact that these are stored as slicable iterables (e.g. #50 and #24) and I'm afraid that having a consistent order might be important for some things as well.
If the data set is going to change, we can hold that off for
rrule2, which will be rearranging the internal structure of rrule dramatically anyway.This also fixes one bug in the
__construct_bysetmethod that I found (albeit one that is currently unreachable).