add document generation to tox #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… check links in documentation to avoid having dangling pointers to the internet)
pganssle
reviewed
Dec 7, 2017
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| from dateutil.tz import tzfile as _tzfile | |||
|
|
|||
| __all__ = ["get_zonefile_instance", "gettz", "gettz_db_metadata", "rebuild"] | |||
| __all__ = ["get_zonefile_instance", "gettz", "gettz_db_metadata"] | |||
There was a problem hiding this comment.
I don't think we can change the public interface like this...
There was a problem hiding this comment.
Hm, actually rebuild is a separate file. Yeah, I see how this works. This is fine.
There was a problem hiding this comment.
the problem here is that this import does not work, the Sphinx could not load it, as no import is there. how is this rebuild suppose to exist?
|
This is awesome, thanks @gaborbernat. I'll merge once CI passes. |
Merged
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and trigger automatically at CI (also check links in documentation to avoid having dangling pointers to the internet)