Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add new build options for setup.py #613

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pganssle
Copy link
Member

@pganssle pganssle commented Jan 18, 2018

Fixes #597.

This will add the --no-zoneinfo, --tzfiles and --tzpath command line arguments so that downstream distributors can easily build versions of this where they are better able to manage how zoneinfo files are distributed.

To do:

  • Add better fallback message for when zoneinfo tarball is not distributed.
  • Add tests
  • Add documentation
  • Possibly forbid these options in things like sdist?
  • Test to see if this can be made to work with pip

CC: @wagner-certat @agx @ericvw @jelly @hguemar

Thoughts from downstream distributors about how much this would help? Would something else be preferable?

The whole thing is a bit of a monstrous hack, unfortunately, but I think it's slightly preferable to everyone patching themselves.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the NEWS file about this new possibility for packagers (so they notice it without digging in the code).

@pganssle
Copy link
Member Author

@wagner-certat The current release procedure doesn't generate the NEWS file until the release is prepared, though I would like to change that with #592.

That said, "add documentation" is one of the bullet points.

@pganssle pganssle modified the milestones: 2.7.0, Feature release Mar 11, 2018
@pganssle pganssle added this to Open in PyData NYC Sprint Apr 11, 2018
@pganssle pganssle removed this from Open in PyData NYC Sprint Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant