-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add new build options for setup.py #613
base: master
Are you sure you want to change the base?
Conversation
4d574e9
to
4988a1b
Compare
4988a1b
to
e1f6ea1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry to the NEWS file about this new possibility for packagers (so they notice it without digging in the code).
@wagner-certat The current release procedure doesn't generate the NEWS file until the release is prepared, though I would like to change that with #592. That said, "add documentation" is one of the bullet points. |
e1f6ea1
to
5b306a9
Compare
Fixes #597.
This will add the
--no-zoneinfo
,--tzfiles
and--tzpath
command line arguments so that downstream distributors can easily build versions of this where they are better able to manage howzoneinfo
files are distributed.To do:
zoneinfo
tarball is not distributed.sdist
?pip
CC: @wagner-certat @agx @ericvw @jelly @hguemar
Thoughts from downstream distributors about how much this would help? Would something else be preferable?
The whole thing is a bit of a monstrous hack, unfortunately, but I think it's slightly preferable to everyone patching themselves.