Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use the Google Favicon API #12

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

naxvog
Copy link
Contributor

@naxvog naxvog commented Jan 10, 2023

Due to GDPR constraints in Europe using a Google API without a corresponding opt-in should be avoided.
This PR introduces a setting to use the API and ignores image and favicon by default.

@datlechin
Copy link
Owner

Thank you, but you don't have to commit dist files, github action will do that.
and fix conflicts

# Conflicts:
#	extend.php
#	js/dist/admin.js
#	js/dist/admin.js.map
#	js/dist/forum.js
#	js/dist/forum.js.map
#	js/src/forum/index.js
@datlechin datlechin merged commit 7907444 into datlechin:master Jan 10, 2023
@naxvog naxvog deleted the google-opt-in branch January 11, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants