Link caching #15
Merged
Link caching #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d58cd0d.
# Conflicts: # src/Api/Controllers/ScrapperController.php
datlechin
reviewed
Jan 11, 2023
| $this->web = $web; | ||
| $this->translator = $translator; | ||
| $this->cache = $cache; | ||
| $cacheTime = $settings->get('datlechin-link-preview.cache_time'); | ||
| if (!is_numeric($cacheTime)) { |
There was a problem hiding this comment.
Can you please elaborate?
Checked the code against PSR-12 and found no issue in the marked segment. Are you referring to an empty line before the if-statement?
There was a problem hiding this comment.
a space after !
by the way, I'll update it later
There was a problem hiding this comment.
Strange I set up my IDE to conform to PSR-12 an even ran PHP_CodeSniffer with the PSR12 preset and the space after the negation operator is removed every time I autoformat using the tool.
datlechin
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caches successfully visited links using the default cache provider according to the set cache time in the backend.
serializeToForm