Fix: Display found preview image while not using the Google favicon API #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d58cd0d.
|
The API response that have |
|
Good catch. The LinkPreview-image Element should not be shown if there is no image and no Google Fallback available. There is however the option to show a default image in such a case, but I prefer the element to not be shown instead as the less code for that is already in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the myriad of PRs but I found an issue failing to display the found image while not using the Google API.
This PR fixes that issue and cleans up the JSX-code (quite rusty with those at the moment).
Feel free to merge/release this whenever as this fix is not a critical one 馃槈