Related discussions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think? |
datlechin
approved these changes
Nov 9, 2023
datlechin
requested changes
Nov 9, 2023
| @@ -55,6 +57,9 @@ export default class MoreDiscussions<CustomAttrs> extends Component { | |||
| limit: this.limit, | |||
| }, | |||
| sort: this.filterBy, | |||
| filter: { | |||
| q: this.isRelated ? app.current.data.discussion.title : null, | |||
There was a problem hiding this comment.
Look like it is app.current.data.discussion.title() not app.current.data.discussion.title
|
Should we add a disclaimer that if the option is activated on big sites without https://github.com/clarkwinkelmann/flarum-ext-scout it's going to affect a lot to site performance? |
|
Yeah, I think so. Can you add a notice to the help text of the Related results field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.