adding tests to controller to list with sort for session, snapshot an…

…d task

datmo/core/controller/test/test_session.py

@@ -7,8 +7,7 @@
 
 from datmo.core.controller.project import ProjectController
 from datmo.core.controller.session import SessionController
-from datmo.core.util.exceptions import EntityNotFound, \
-    GitCommitDoesNotExist, SessionDoesNotExistException
+from datmo.core.util.exceptions import InvalidArgumentType
 
 class TestSessionController():
     def setup_method(self):
@@ -67,6 +66,29 @@ def test_get_session_sort(self):
         sessions = self.session.list(sort_key='created_at', sort_order='descending')
         assert sessions[0].created_at >= sessions[-1].created_at
 
+        # Wrong order being passed in
+        failed = False
+        try:
+            _ = self.session.list(sort_key='created_at', sort_order='wrong_order')
+        except InvalidArgumentType:
+            failed = True
+        assert failed
+
+        # Wrong key and order being passed in
+        failed = False
+        try:
+            _ = self.session.list(sort_key='wrong_key', sort_order='wrong_order')
+        except InvalidArgumentType:
+            failed = True
+        assert failed
+
+        # wrong key and right order being passed in
+        expected_sessions = self.session.list(sort_key='created_at', sort_order='ascending')
+        sessions = self.session.list(sort_key='wrong_key', sort_order='ascending')
+        expected_ids = [item.id for item in expected_sessions]
+        ids = [item.id for item in sessions]
+        assert set(expected_ids) == set(ids)
+
     def test_delete_session(self):
         self.session.create({"name": "test3"})
         new_current = self.session.select("test3")

datmo/core/controller/test/test_snapshot.py

@@ -16,7 +16,7 @@
 from datmo.core.util.exceptions import EntityNotFound, \
     EnvironmentDoesNotExist, GitCommitDoesNotExist, \
     SessionDoesNotExistException, RequiredArgumentMissing, \
-    TaskNotComplete
+    TaskNotComplete, InvalidArgumentType
 
 
 class TestSnapshotController():
@@ -419,6 +419,29 @@ def test_list(self):
                snapshot_obj_2 in result
         assert result[0].created_at >= result[-1].created_at
 
+        # Wrong order being passed in
+        failed = False
+        try:
+            _ = self.snapshot.list(sort_key='created_at', sort_order='wrong_order')
+        except InvalidArgumentType:
+            failed = True
+        assert failed
+
+        # Wrong key and order being passed in
+        failed = False
+        try:
+            _ = self.snapshot.list(sort_key='wrong_key', sort_order='wrong_order')
+        except InvalidArgumentType:
+            failed = True
+        assert failed
+
+        # wrong key and right order being passed in
+        expected_result = self.snapshot.list(sort_key='created_at', sort_order='ascending')
+        result = self.snapshot.list(sort_key='wrong_key', sort_order='ascending')
+        expected_ids = [item.id for item in expected_result]
+        ids = [item.id for item in result]
+        assert set(expected_ids) == set(ids)
+
         # List all snapshots with session filter
         result = self.snapshot.list(session_id=
                                     self.project.current_session.id)

datmo/core/controller/test/test_task.py

@@ -16,7 +16,7 @@
 from datmo.core.controller.project import ProjectController
 from datmo.core.controller.environment.environment import EnvironmentController
 from datmo.core.controller.task import TaskController
-from datmo.core.util.exceptions import EntityNotFound, TaskRunException
+from datmo.core.util.exceptions import EntityNotFound, TaskRunException, InvalidArgumentType
 
 
 class TestTaskController():
@@ -365,6 +365,29 @@ def test_list(self):
                task_obj_2 in result
         assert result[0].created_at >= result[-1].created_at
 
+        # Wrong order being passed in
+        failed = False
+        try:
+            _ = self.task.list(sort_key='created_at', sort_order='wrong_order')
+        except InvalidArgumentType:
+            failed = True
+        assert failed
+
+        # Wrong key and order being passed in
+        failed = False
+        try:
+            _ = self.task.list(sort_key='wrong_key', sort_order='wrong_order')
+        except InvalidArgumentType:
+            failed = True
+        assert failed
+
+        # wrong key and right order being passed in
+        expected_result = self.task.list(sort_key='created_at', sort_order='ascending')
+        result = self.task.list(sort_key='wrong_key', sort_order='ascending')
+        expected_ids = [item.id for item in expected_result]
+        ids = [item.id for item in result]
+        assert set(expected_ids) == set(ids)
+
         # List all tasks and filter by session
         result = self.task.list(session_id=
                                 self.project.current_session.id)