Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time querying for the db #32

Closed
shabazpatel opened this issue Apr 27, 2018 · 5 comments
Closed

time querying for the db #32

shabazpatel opened this issue Apr 27, 2018 · 5 comments
Assignees
@pennyfx
Projects
datmo
Milestone
0.1.0

Comments

@shabazpatel
Copy link
Member

No description provided.

@shabazpatel shabazpatel created this issue from a note in datmo (To do) Apr 27, 2018
@asampat3090 asampat3090 changed the title time querying? time querying for the db Apr 27, 2018
@asampat3090 asampat3090 moved this from To do to In progress in datmo Apr 27, 2018
@pennyfx
Copy link
Contributor

pennyfx commented Apr 27, 2018

I think this should work. {"time": {"gte": 1}}

@pennyfx
Copy link
Contributor

pennyfx commented Apr 30, 2018 •
edited

  • Add tests showing how this works

pennyfx pushed a commit that referenced this issue Apr 30, 2018
Added tests to prove range queries work #32
c398e40
@pennyfx
Copy link
Contributor

pennyfx commented Apr 30, 2018

@asampat3090 Check out the tests to see how range queries work.

@pennyfx pennyfx closed this as completed Apr 30, 2018
@asampat3090
Copy link
Member

@pennyfx I made a comment on the commit, but how exactly would this be passed at the higher level? Are the query parameters supposed to be passed in in mongo db query format? that doesn't seem extensible to other query formats. Or we'll we have to maintain that this query format is what we will always be able to handle?

@pennyfx
Copy link
Contributor

pennyfx commented Apr 30, 2018

It seems to be pretty standard for document databases.

https://docs.mongodb.com/manual/reference/operator/query/

http://docs.couchdb.org/en/2.0.0/api/database/find.html

asampat3090 added a commit that referenced this issue May 1, 2018
@asampat3090
Merge branch 'master' into issue-36
2b5e0cc 
* master: (27 commits)
  hotfix to remove pdb
  Fixed project to test
  hotfix for passing task tests for cli command
  Fix
  Don't modify kwargs
  add in tests and handling to allow inputs and for mutually exclusive args.
  1) aesthetic changes to match PEP8 2) remove visible from cli input 3) split out tests for snapshot create cli command
  cleanup
  adding default cli argument as None and check before creation of snapshot dictionary
  Fixed Exception name
  Accept dictionary objects to .create
  Always scope entity queries to model_id
  Query snapshot with model_id
  passing which entity can't be found when throwing EntityCollectionNotFound
  Added tests to prove range queries work #32
  Split up tests
  Added new lang keys for session
  Added session CLI commands with tests
  Fix to work with mongo driver
  Delete snapshots and tasks that were created with a session
  ...
@asampat3090 asampat3090 moved this from In progress to Done in datmo May 1, 2018
@asampat3090 asampat3090 added this to the 0.1.0 milestone May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pennyfx pennyfx

Labels
None yet
Projects
No open projects
datmo
  
Done
Milestone
0.1.0
Development

No branches or pull requests
3 participants
@pennyfx @asampat3090 @shabazpatel