Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 'home' #57

Closed
pennyfx opened this issue May 1, 2018 · 6 comments
Closed

Refactor 'home' #57

pennyfx opened this issue May 1, 2018 · 6 comments
Assignees
@pennyfx @asampat3090
Labels
enhancement
Projects
datmo
Milestone
0.1.0

Comments

@pennyfx
Copy link
Contributor

pennyfx commented May 1, 2018

Create a global home property, that can be used everywhere instead of having to pass home down to all components.
@pennyfx pennyfx self-assigned this May 1, 2018
@pennyfx pennyfx added enhancement research Research, discovery and report findings labels May 4, 2018
@asampat3090 asampat3090 added this to Done in datmo May 6, 2018
@asampat3090 asampat3090 moved this from Done to backlogs in datmo May 6, 2018
@asampat3090
Copy link
Member

This would be really great to have in future versions. Keeping this in backlogs for now. Labeling it as "details needed" for the time being.

@asampat3090 asampat3090 added the details needed Requires more details to be promoted label May 7, 2018
@asampat3090
Copy link
Member

Some version of this is included in PR #134, but we will want to look at the specific commits / methods to implement this in the master branch. Will wait on some more detailed commits before looking into it.

@asampat3090
Copy link
Member

Looks like some of this is currently in PR #134 but will need to be reviewed and potentially cherry-picked from changes.

@asampat3090 asampat3090 self-assigned this Jun 9, 2018
@asampat3090 asampat3090 removed details needed Requires more details to be promoted research Research, discovery and report findings labels Jun 9, 2018
@asampat3090 asampat3090 added this to the 0.1.0 milestone Jun 9, 2018
@asampat3090
Copy link
Member

cherry-picked this commit from the mongo branch : fe5c0eb

and added it to the "simplify" branch.

@asampat3090
Copy link
Member

fixed on simplify branch : https://github.com/datmo/datmo/tree/simplify

commit : b3a3d6c

@asampat3090
Copy link
Member

closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pennyfx pennyfx

@asampat3090 asampat3090

Labels
enhancement
Projects
No open projects
datmo
  
backlogs
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@pennyfx @asampat3090