Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB (DO NOT MERGE) #134

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

MongoDB (DO NOT MERGE) #134

wants to merge 12 commits into from

Conversation

pennyfx
Copy link
Contributor

@pennyfx pennyfx commented May 17, 2018

There's a few things on this branch.

  1. Works with MongoDB
  2. Added model_id to all queries so that things are properly scoped, which surfaced various errors in our tests as well.
  3. Removed (home) from all controllers/commands and instead use Config().set_home() function, so that home dir is not passed everywhere.
  4. Various refactoring

For mongodb to work properly, there needs to be a way for the user to configure the credentials. Right now it's hard coded here

perhaps something like datmo config --db="mongodb://user:pwd@host:port/db"

@pennyfx pennyfx self-assigned this May 17, 2018
@pennyfx pennyfx force-pushed the mongo branch 2 times, most recently from 93fb8cb to 2530ac0 Compare May 17, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant