Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment workspace #242

Merged
merged 14 commits into from Jul 27, 2018
Merged

environment workspace #242

merged 14 commits into from Jul 27, 2018

Conversation

shabazpatel
Copy link
Member

@shabazpatel shabazpatel commented Jul 23, 2018

  1. Fix the environment setup while no language
  2. Adding quit option Environment setup needs an exit character option #197
  3. Hotfix for the rerun to be able to rerun workspace
  4. Added test for prompt_available_options in test_helper
  5. Added automatic workspace opening in web browser Workspace commands should open up the workspace after the command is run  #209

Copy link
Member

@asampat3090 asampat3090 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add testing for the q and quit functions

@coveralls
Copy link

coveralls commented Jul 23, 2018

Pull Request Test Coverage Report for Build 945

  • 42 of 56 (75.0%) changed or added relevant lines in 6 files are covered.
  • 48 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.1%) to 87.274%

Changes Missing Coverage Covered Lines Changed/Added Lines %
datmo/cli/driver/helper.py 3 4 75.0%
datmo/cli/command/workspace.py 0 2 0.0%
datmo/core/controller/environment/driver/dockerenv.py 21 26 80.77%
datmo/core/controller/task.py 5 11 45.45%
Files with Coverage Reduction New Missed Lines %
datmo/cli/command/base.py 1 92.96%
datmo/snapshot.py 1 83.49%
datmo/core/controller/file/driver/local.py 2 91.92%
datmo/cli/command/datmo_command.py 2 100.0%
datmo/core/util/i18n.py 2 100.0%
datmo/cli/command/run.py 2 81.5%
datmo/core/controller/code/driver/file.py 2 93.99%
datmo/cli/command/snapshot.py 2 100.0%
datmo/cli/command/session.py 2 95.7%
datmo/core/util/json_store.py 6 84.62%
Totals Coverage Status
Change from base Build 914: -0.1%
Covered Lines: 3957
Relevant Lines: 4534

💛 - Coveralls

@asampat3090
Copy link
Member

asampat3090 commented Jul 26, 2018

Tested this on a MacOSX High Sierra 10.13.6 w/ Anaconda Python 3.6 and the following errors occurred when the following was run -- got the same error for jupyterlab as well.

$ datmo notebook
...
Exception in thread Thread-3:
Traceback (most recent call last):
  File "/Users/anandsampat/anaconda3/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/Users/anandsampat/anaconda3/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/anandsampat/anaconda3/lib/python3.6/site-packages/datmo-0.0.22.dev0-py3.6.egg/datmo/core/controller/task.py", line 156, in _open_workspace
    workspace_url = self.environment_driver.extract_workspace_url(name, workspace)
  File "/Users/anandsampat/anaconda3/lib/python3.6/site-packages/datmo-0.0.22.dev0-py3.6.egg/datmo/core/controller/environment/driver/dockerenv.py", line 476, in extract_workspace_url
    result = re.search("(?P<url>https?://[^\s]+)", stdout) if stdout else None
  File "/Users/anandsampat/anaconda3/lib/python3.6/re.py", line 182, in search
    return _compile(pattern, flags).search(string)
TypeError: cannot use a string pattern on a bytes-like object

@asampat3090 asampat3090 merged commit f39adf0 into master Jul 27, 2018
@asampat3090 asampat3090 deleted the environment-workspace branch July 27, 2018 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants