Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker install instructions for MacOS + Ubuntu + windows in hello world docs example #260

Merged
merged 2 commits into from
Aug 21, 2018

Conversation

nmwalsh
Copy link
Contributor

@nmwalsh nmwalsh commented Aug 21, 2018

No description provided.

@coveralls
Copy link

coveralls commented Aug 21, 2018

Pull Request Test Coverage Report for Build 1037

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 52 unchanged lines in 15 files lost coverage.
  • Overall coverage remained the same at 87.88%

Files with Coverage Reduction New Missed Lines %
datmo/cli/command/base.py 1 93.98%
datmo/snapshot.py 1 83.49%
datmo/cli/command/datmo_command.py 2 100.0%
datmo/core/util/i18n.py 2 100.0%
datmo/cli/command/run.py 2 81.57%
datmo/core/controller/file/driver/local.py 2 91.95%
datmo/logger.py 2 92.59%
datmo/cli/command/snapshot.py 2 100.0%
datmo/cli/command/session.py 2 95.7%
datmo/core/controller/code/driver/file.py 2 94.12%
Totals Coverage Status
Change from base Build 1033: 0.0%
Covered Lines: 4133
Relevant Lines: 4703

💛 - Coveralls

@shabazpatel
Copy link
Member

shabazpatel commented Aug 21, 2018

@nmwalsh Can you also add it for windows? https://github.com/datmo/hello-world

@shabazpatel shabazpatel changed the title Add Docker install instructions for MacOS + Ubuntu in hello world docs example Add Docker install instructions for MacOS + Ubuntu + windows in hello world docs example Aug 21, 2018
@shabazpatel shabazpatel self-requested a review August 21, 2018 22:39
@shabazpatel shabazpatel merged commit 95d1099 into master Aug 21, 2018
@shabazpatel shabazpatel deleted the new-hello-world branch August 21, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants