Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/query artifact from metadata api #72

Merged
merged 14 commits into from
Feb 3, 2024

Conversation

datnguye
Copy link
Owner

@datnguye datnguye commented Feb 3, 2024

feat only for #68

Description

New command dbterd run-metadata [-s <dbterd selection>] to query ERD data from Discovery API, and generate the ERD file on fly

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 131 lines in your changes are missing coverage. Please review.

Comparison is base (d5a1590) 100.00% compared to head (3fd5ee9) 85.60%.
Report is 1 commits behind head on main.

Files Patch % Lines
dbterd/adapters/algos/base.py 43.63% 62 Missing ⚠️
dbterd/adapters/dbt_cloud/discovery.py 31.57% 26 Missing ⚠️
dbterd/adapters/dbt_cloud/graphql.py 37.50% 15 Missing ⚠️
dbterd/adapters/algos/test_relationship.py 23.07% 10 Missing ⚠️
dbterd/adapters/dbt_cloud/query.py 37.50% 10 Missing ⚠️
dbterd/adapters/base.py 83.72% 7 Missing ⚠️
dbterd/cli/main.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main      #72       +/-   ##
============================================
- Coverage   100.00%   85.60%   -14.40%     
============================================
  Files           28       31        +3     
  Lines          713      910      +197     
============================================
+ Hits           713      779       +66     
- Misses           0      131      +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datnguye datnguye merged commit 2ae1867 into main Feb 3, 2024
12 of 14 checks passed
@datnguye datnguye deleted the feat/query-artifact-from-metadata-api branch February 3, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant