Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase node_name in comparison to match even if it is uppercase #74

Merged

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Feb 6, 2024

resolves #73

Description

Fixed a bug that prevented ER diagrams from being output when data source table names were capitalized. This is because the rule part is lower(), but lower is not applied in the is_satisfied_by_exact function. Therefore, the result of the is_selected_table function was determined to be false, and the ER diagram was not output as expected.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@syou6162 syou6162 marked this pull request as ready for review February 6, 2024 16:28
@syou6162 syou6162 force-pushed the fix_is_satisfied_by_exact_even_if_capitalized branch from 3527a26 to b4447a2 Compare February 7, 2024 01:19
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ae1867) 85.60% compared to head (b4447a2) 85.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files          31       31           
  Lines         910      910           
=======================================
  Hits          779      779           
  Misses        131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datnguye datnguye merged commit 0d13cba into datnguye:main Feb 7, 2024
12 checks passed
@syou6162 syou6162 deleted the fix_is_satisfied_by_exact_even_if_capitalized branch February 7, 2024 02:50
datnguye pushed a commit that referenced this pull request Feb 7, 2024
* Lowercase node_name in comparison to match even if it is uppercase

* Add test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ER diagram is not output when node_name is capitalized
2 participants