Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omit_columns option to mermaid #77

Merged
merged 7 commits into from
Feb 8, 2024

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Feb 8, 2024

resolves #78

Description

I added --omit_columns option to omit columns from diagrams when the output format is mermaid.

I thought about omitting columns for --target other than mermaid, but since dbml, for example, requires at least one column, I decided to support only --target = mermaid.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ae1867) 85.60% compared to head (b172040) 85.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   85.60%   85.68%   +0.07%     
==========================================
  Files          31       31              
  Lines         910      915       +5     
==========================================
+ Hits          779      784       +5     
  Misses        131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syou6162 syou6162 marked this pull request as ready for review February 8, 2024 06:48
dbterd/cli/params.py Outdated Show resolved Hide resolved
@datnguye datnguye merged commit a6cf5f4 into datnguye:main Feb 8, 2024
12 checks passed
@syou6162 syou6162 deleted the feature/add_omit_columns branch February 8, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add options to omit columns from diagram
2 participants