Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows drawing recursive relationships #89

Merged

Conversation

syou6162
Copy link
Contributor

@syou6162 syou6162 commented Feb 17, 2024

resolves #88

Description

This modification allows a diagram to be drawn even if it has the following recursive relationship.

erDiagram
  "MY_PROJECT.CATEGORY" {
  }
  "MY_PROJECT.CATEGORY" }|--|| "MY_PROJECT.CATEGORY": categoryid--parentCategoryId
Loading

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f704cf8) 100.00% compared to head (681134f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #89   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          959       961    +2     
=========================================
+ Hits           959       961    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syou6162 syou6162 marked this pull request as draft February 17, 2024 15:56
@syou6162 syou6162 force-pushed the feature/allow_drawing_recursive_relationships branch from 788ec8b to 32fabeb Compare February 17, 2024 15:57
@syou6162 syou6162 force-pushed the feature/allow_drawing_recursive_relationships branch from 32fabeb to 681134f Compare February 17, 2024 16:03
@syou6162 syou6162 marked this pull request as ready for review February 17, 2024 16:05
@datnguye datnguye merged commit d8f8209 into datnguye:main Feb 18, 2024
12 checks passed
@datnguye
Copy link
Owner

LGTM thanks @syou6162

@syou6162 syou6162 deleted the feature/allow_drawing_recursive_relationships branch February 18, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Allows drawing recursive relationships
2 participants