Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling metadata catalog null & self rel #90

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

datnguye
Copy link
Owner

resolves #87

Description

  • Handling metadata catalog null
  • Supporting Self-relationship with 1 parent model

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f704cf8) 100.00% compared to head (dc0e204) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          959       965    +6     
=========================================
+ Hits           959       965    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datnguye datnguye merged commit 6b3bba5 into main Feb 18, 2024
14 checks passed
@datnguye datnguye deleted the fix/87-handling-catalog-null branch February 18, 2024 08:11
datnguye added a commit that referenced this pull request Feb 18, 2024
* fix: handling metadata catalog null & self rel

* chore: code format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Ephemeral Models have {"catalog": null} using Discovery API - Column Error
1 participant