Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local airflow with load code for local csv converting to json #3

Closed
5 tasks done
hannelita opened this issue Jun 8, 2020 · 4 comments
Closed
5 tasks done

Local airflow with load code for local csv converting to json #3

hannelita opened this issue Jun 8, 2020 · 4 comments
Assignees

Comments

@hannelita
Copy link
Contributor

hannelita commented Jun 8, 2020

local airflow with load code for local csv converting to json. Part of Epic #1

Acceptance

  • Parameterized task on examples/folder; receives a csv file and outputs a pretty printed json file

Tasks

  • Define airflow operator (PythonOperator for now)
  • Libraries - converting with pandas
  • Specify in/out directories in kwargs
  • Json Pretty Printing
  • wrap up DAG code

Analysis

Questions

  • How to deal with invalid CSV files? This may deserve another issue on the tracker
    • ~rufus definitely deserves another item. Here you assume the CSV's are "tidy/good"
  • tests? (unsure how to do them for this example case)
    • ~rufus - what are you testing? there's the core lib for processing and airflow itself. For airflow itself it would be more UAT like e.g. calling the API and checking there's some output on disk
  • Formatting scripts/libraries? Ideally set them up with tests (i.e. run make test and also get feedback from formatting)
    • ~rufus: can you clarify what you mean by formatting scripts / lib.
@rufuspollock
Copy link
Member

@hannelita can we get acceptance section items on this? I've also formatted sections as https://playbook.datopian.com/issues-tasks/ and answered the questions.

@hannelita
Copy link
Contributor Author

Formatting libs => Create a pytest.ini with flake8, isort and other libraries.

@hannelita
Copy link
Contributor Author

Update: @sglavoie will review the PR and help with tests setup

@rufuspollock
Copy link
Member

FIXED. Merged in PR #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants