Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tune the number of rows needed for preview resources #32

Closed
akariv opened this issue Sep 25, 2017 · 5 comments
Closed

Fine-tune the number of rows needed for preview resources #32

akariv opened this issue Sep 25, 2017 · 5 comments
Assignees

Comments

@akariv
Copy link
Collaborator

akariv commented Sep 25, 2017

Choose a good number of rows for previewing the data (based on our current core datasets).

@zelima
Copy link
Collaborator

zelima commented Sep 29, 2017

@anuveyatsu Can you decide on this?

@zelima zelima added this to the Sprint - 9 Oct 2017 milestone Sep 29, 2017
@anuveyatsu
Copy link
Member

anuveyatsu commented Sep 29, 2017

@zelima I think 1k is pretty enough. Do you ever scroll a table with 1k rows to the end? I think even 100 would be OK, but let's do 1k for now so it should improve the loading speed of some large datasets.

@zelima
Copy link
Collaborator

zelima commented Sep 29, 2017

Hm... this makes me think about how we are going to deal with sorting data that is time sensitive. Eg: for Finance Vix, that is updated daily, we need last 1000 rows (or maybe first for other datasets), to display the latest data
cc @rufuspollock and @akariv

zelima added a commit that referenced this issue Oct 2, 2017
* [previews][s]: skip creation of preview resource -refs #31
* [previews][xs]: reduce default limti till 200 -refs #32
@zelima
Copy link
Collaborator

zelima commented Oct 2, 2017

FIXED. As discussed in person we reduced it till 200. Followup showing first/last part of dataset here #39

@zelima zelima closed this as completed Oct 2, 2017
@zelima
Copy link
Collaborator

zelima commented Oct 5, 2017

This is back to 10,000 now, as suggested by @rufuspollock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants