Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests for pdf preview. #7

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Remove tests for pdf preview. #7

merged 1 commit into from
Nov 20, 2020

Conversation

higorspinto
Copy link
Contributor

Closes #6

  • remove any test that checks for pdf previews

cuducos
cuducos approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@cuducos cuducos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I got, the preview cannot be taken for granted, right? So… approved 👍

@higorspinto
Copy link
Contributor Author

As far as I got, the preview cannot be taken for granted, right? So… approved

Yes, pdf previews require ckanext-pdfview.

@higorspinto higorspinto merged commit 252e559 into main Nov 20, 2020
@higorspinto higorspinto deleted the fix/remove-pdf-preview-tests branch November 20, 2020 20:26
@cuducos cuducos mentioned this pull request Nov 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuducos cuducos cuducos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove test for PDF preview
2 participants
@higorspinto @cuducos