[#384] add validator to validate user input. #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aliounedia do we have any tests for this? (I couldn't see one - so sorry if i missed it!). Really think a test of some kind would be really good (though may be very hard to do - not sure how to trigger an edit ...). If its impossible don't worry and we'll just test by hand ;-) |
|
@rgrp ya, you are right , we should have a test , let me add some, I had tested with our working app that use |
|
@rgrp tests add /row delete was added to slickgrid Tests completed in 1835 milliseconds. |
rufuspollock
added a commit
that referenced
this pull request
Jan 22, 2014
[#384] add validator to validate user input.
aliounedia
added a commit
to aliounedia/recline
that referenced
this pull request
Feb 4, 2014
rufuspollock
added a commit
that referenced
this pull request
Feb 5, 2014
[#385]add row add delete support for reclinejs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.