Change default tiles for map view, allow customization #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the MapQuest debacle, there was a patch merged that replaced the MapQuest tiles with the OpenStreetMap ones (#501). IMO these are not a good default choice because while they might be fine for a small Recline project, heavy usage of them goes against their Terms of Use: http://wiki.openstreetmap.org/wiki/Tile_usage_policy More specifically: > Heavy use (e.g. distributing an app that uses tiles from openstreetmap.org) > is forbidden without prior permission from the System Administrators Popular CKAN instances that use Recline are likely to fall in this category. And also: > Highly Recommended: Do not hardcode any URL at tile.openstreetmap.org > into an app. This patch replaces the tiles with the Terrain tileset from Stamen (http://maps.stamen.com), which have more liberal terms. But more crucially, as this is something that different people will have different views on, it allows you to configure the tiles used by passing custom options to the view constructor, eg: view = new recline.View.Map({ model: dataset, mapTilesURL: '//{s}.tiles.mapbox.com/v4/mapbox.mapbox-streets-v7/{z}/{x}/{y}.png?access_token=pk.XXXX', mapTilesAttribution: '© MapBox etc..', mapTilesSubdomains: 'ab' }) So everybody (and apps integrating Recline like CKAN) can configure the tiles as they want.
|
Any ideas as to why the tests are failing on Travis? I'm not familiar with this suite and they pass for me locally. |
|
@amercader not sure why tests fail but looks good so happy for you merge if you want. |
|
@rgrp fixed the tests, merging |
amercader
added a commit
to ckan/ckan
that referenced
this pull request
Aug 12, 2016
This includes datopian/datahub#502 which helps with #3174
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the MapQuest debacle, there was a patch merged that replaced the MapQuest tiles with the OpenStreetMap ones (#501). IMO these are not a good default choice because while they might be fine for a small Recline project, heavy usage of them goes against their Terms of Use:
http://wiki.openstreetmap.org/wiki/Tile_usage_policy
More specifically:
Popular CKAN instances that use Recline are likely to fall in this category.
This patch replaces the tiles with the Terrain tileset from Stamen (http://maps.stamen.com), which has more liberal terms.
But more crucially, as this is something that different people will have different views on, it allows you to configure the tiles used by passing custom options to the view constructor, eg:
So everybody (and apps integrating Recline like CKAN) can configure the tiles as they want.