Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components]: Search functionality feature on website #78

Closed
wants to merge 10 commits into from

Conversation

khalilcodes
Copy link
Contributor

Search component

Tasks from #34


This PR adds a doc search feature to the website.

Tasks

Notes

Required to add algolia configs as env variables:

  • API key,
  • App ID,
  • Index name

Screenshots

Screen Shot 2022-08-03 at 8 29 38 PM

Screen Shot 2022-08-03 at 8 29 51 PM

@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for spectacular-dragon-c1015c failed.

Name Link
🔨 Latest commit 48df9b8
🔍 Latest deploy log https://app.netlify.com/sites/spectacular-dragon-c1015c/deploys/62f288f967820c0009f0eda6

@olayway olayway self-requested a review August 8, 2022 11:29
Copy link
Member

@rufuspollock rufuspollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me - one thing missing are some short docs. Docs should probably be split into:

  • user section explaining what search is and maybe short screenshot.
  • admin section explaining how to configure (e.g. what fields need to be set where)

@rufuspollock
Copy link
Member

@khalilcodes this now has conflicts so i can't merge.

@khalilcodes
Copy link
Contributor Author

Yes will merge along with added docs.

@khalilcodes
Copy link
Contributor Author

khalilcodes commented Aug 9, 2022

The build seems to be failing here for some reason (suspecting package-lock after merge). Here's some more info on why the build can fail - https://nextjs.org/docs/messages/failed-loading-swc

I will close this and create a new branch with PR as the commits have become messy here.

@khalilcodes khalilcodes closed this Aug 9, 2022
@khalilcodes khalilcodes deleted the 34-feature-search branch August 10, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants