Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#49, Add body tags extraction] #57

Merged
merged 1 commit into from Nov 17, 2023
Merged

[#49, Add body tags extraction] #57

merged 1 commit into from Nov 17, 2023

Conversation

mohamedsalem401
Copy link
Member

Function and tests for extracting tags from both headings and body text.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2023

⚠️ No Changeset found

Latest commit: fed0e28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rufuspollock
rufuspollock approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@rufuspollock rufuspollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Good set of tests. Let's get this merged.

src/utils/extractTagsFromBody.spec.ts
expect(tags).toEqual(expectedTags);
});

test("should extract 2 tags from heading", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@mohamedsalem401 mohamedsalem401 merged commit 30106b7 into v2 Nov 17, 2023
@mohamedsalem401 mohamedsalem401 mentioned this pull request Nov 17, 2023
Closed
2 tasks
@mohamedsalem401 mohamedsalem401 deleted the body-tags branch November 24, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rufuspollock rufuspollock rufuspollock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohamedsalem401 @rufuspollock