Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frictionless view #5

Merged
merged 11 commits into from
Mar 1, 2021
Merged

Add frictionless view #5

merged 11 commits into from
Mar 1, 2021

Conversation

risenW
Copy link
Contributor

@risenW risenW commented Feb 26, 2021

This pull fixes #4

@rufuspollock
Copy link
Member

@risenW i've reviewed and looks reasonable. If this ready to merge go ahead and merge it ...

My one comment is that whilst you are doing a view with inline resource right now we want to rapidly move to where the resource is inferred from the resources in the parent dataset (i.e. we go back to the way the Frictionless dataset was b4 this commit). However, i assumed that you wanted to get the simple thing working and then do the more complex setup.

@risenW
Copy link
Contributor Author

risenW commented Mar 1, 2021

@risenW i've reviewed and looks reasonable. If this ready to merge go ahead and merge it ...

My one comment is that whilst you are doing a view with inline resource right now we want to rapidly move to where the resource is inferred from the resources in the parent dataset (i.e. we go back to the way the Frictionless dataset was b4 this commit). However, i assumed that you wanted to get the simple thing working and then do the more complex setup.

Thanks, and yes, I'm stubbing the data view for now. This works and can be displayed in the dataset page, so today I'm working on inferring from the resource

@risenW risenW changed the title [WIP] Add frictionless view Add frictionless view Mar 1, 2021
@risenW risenW merged commit fa442c9 into main Mar 1, 2021
@risenW risenW deleted the feature/views branch March 2, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Frictionless views in dataset page
2 participants