Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

236 add max min aggs #256

Merged
merged 5 commits into from
Apr 12, 2018
Merged

236 add max min aggs #256

merged 5 commits into from
Apr 12, 2018

Conversation

lucaslavandeira
Copy link
Contributor

Closes #236

  • Muevo código que formatea la respuesta recibida de ES a un módulo aparte
  • Modifico dicho código para que pueda leer resultados desde aggregations de ES en ciertos casos
  • Implemento max y min usando aggregations de ES

@lucaslavandeira lucaslavandeira added this to ToDo in Servicios - Sprint 9 via automation Apr 12, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 83.036% when pulling 34bbc61 on 236-add-max-min-aggs into 41b285a on master.

@lucaslavandeira lucaslavandeira moved this from ToDo to In Progress in Servicios - Sprint 9 Apr 12, 2018
@leandro-gomez
Copy link
Contributor

Metiste un refactor en el medio, no?

@lucaslavandeira lucaslavandeira merged commit 29c1deb into master Apr 12, 2018
@lucaslavandeira lucaslavandeira moved this from In Progress to Done in Servicios - Sprint 9 Apr 12, 2018
@lucaslavandeira lucaslavandeira deleted the 236-add-max-min-aggs branch July 17, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandro-gomez leandro-gomez leandro-gomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Servicios - Sprint 9
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucaslavandeira @coveralls @leandro-gomez