Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a 1.0 release? #64

Open
orbeckst opened this issue Feb 9, 2017 · 11 comments
Open

make a 1.0 release? #64

orbeckst opened this issue Feb 9, 2017 · 11 comments

Comments

@orbeckst
Copy link
Contributor

orbeckst commented Feb 9, 2017

The docs still state that this is alpha software but I think in truth it has been in stable use for more than a year. Isn't it time to slap a 1.0 on it?

(Or are we waiting for MDAnalysis 0.16.0?)

@kain88-de
Copy link
Contributor

I would say after this datreant issue datreant/datreant#100 has been resolved we can go for a 1.0 release. Solving that issue will mean that old sim files need to be changed by the user to still function.

@orbeckst
Copy link
Contributor Author

orbeckst commented Jul 4, 2018

ping @dotsdl – ready to 🚢 ?

@kain88-de
Copy link
Contributor

ping @dotsdl

anything holding this back? The new datreant libraries are shipped and the develop branch is tested well

@dotsdl
Copy link
Member

dotsdl commented Sep 30, 2018

@kain88-de only the docs. Hacking on this now.

@dotsdl
Copy link
Member

dotsdl commented Sep 30, 2018

Just realized that we have to graft datreant.data.agglimbs.AggData onto Bundle and View, as well as datreant.data.limbs.Data onto Tree if we want to maintain the full data functionality. We do this either with subclassing or monkey-patching to the classes, neither of which is very satisfying to me. I'm tempted to ditch data entirely, but that's easy for me to say because I don't myself depend on it.

@kain88-de, thoughts? This whole library is a bit of a shim in my view, so I'm not inclined to expend too much effort to keep it all running.

@kain88-de
Copy link
Contributor

I thought we have most of the data functionality ported into mdsynthesis by now? The AggData is to work on a bundle?

@dotsdl
Copy link
Member

dotsdl commented Oct 5, 2018

Yeah, AggData is for Bundles (and Views), while Data is for Treants (and Trees). I think what I'll do is subclass Bundle from datreant and graft AggData onto it, then we'll cut our losses and forget trying to get these limbs to work for View and Tree, since that takes us down a rabbit hole. Subclassing Bundle is already well-motivated since we want the MDS Bundle to handle Sims and only Sims.

@kain88-de
Copy link
Contributor

kain88-de commented Oct 5, 2018 via email

@dotsdl
Copy link
Member

dotsdl commented Oct 5, 2018

No worries, I can handle this. I often get stuck in the mud when I know what my needs are (not MDSynthesis), but don't know what users expect to keep working. I'll proceed with the path I laid out, and trim the docs down accordingly.

@kaceyaurum
Copy link
Contributor

I love mdsynthesis; make a 1.0 already! As long as the basics (bundles!) work, people will be happy.

@orbeckst
Copy link
Contributor Author

A 1.0 would be nice – then it's done. conda installs MDS 0.6.1, which seems to be happy with datreant 1.0 – I hope this works...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants