Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make installable #5

Closed
kain88-de opened this issue Jul 28, 2018 · 8 comments
Closed

make installable #5

kain88-de opened this issue Jul 28, 2018 · 8 comments

Comments

@kain88-de
Copy link
Contributor

The script is basically done. But right now I can't figure out how to write the setup.py correctly

@datreant/coredevs any idea?

@kain88-de
Copy link
Contributor Author

@orbeckst Maybe you are interested in this too. I didn't do a lot of testing but it should allow to write bash code like this

for folder in $(dtr search simulations --tags GB3 --categories gromacs:2016.4)
do
    # run some GROMACS functions or other things.
done

@richardjgowers
Copy link

@kain88-de if this is finished can we not just include it into the main package?

@kain88-de
Copy link
Contributor Author

Nothing speaking against it but I'm not using click so this would mean adding another dependency. I see nothing against having this as a stand-alone package for some time and using it to see if we need to change it.

@orbeckst
Copy link

Does datreant.cli still thinks that datreant has namespace packages – is this the problem?

@kain88-de
Copy link
Contributor Author

Nope it doesn't. We can also use a hyphen instead of the dot so name it datreant-cli. I'm not aware the dot is a problem but worth a check.

@dotsdl
Copy link
Member

dotsdl commented Aug 2, 2018

Unless something has changed in the python import system last time I researched it (>3 years ago), the dot would be a problem for importing the module. If you try to import datreant.cli and the import system finds the datreant package first, it won't find a cli module and would give on ImportError. A namespace package avoids this by being an umbrella in which nothing really lives but under which a bunch of modules are available.

See my comment in #4: let's make the CLI interface part of the datreant package itself.

@kain88-de
Copy link
Contributor Author

yup replacing the dot with an underscore worked.

So this can be tested now. There will be bugs. I have not done any testing yet. I still have to update all of my projects to actually use the new datreant version.

@kain88-de
Copy link
Contributor Author

See 7e19586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants