-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge into core? #4
Comments
Because I didn’t update it yet with regard to core? There is I believe still some stuff that doesn’t work yet. Like the tag and category selection. Once everything works we can think about moving it to core. |
Sure but the reason .data is separate is to keep weighty dependencies out. Is there a reason to keep cli out of the default/base package? |
Not really. But having this single script separate at first is nice to test things. If we find it works good. Is with master we can see if we want to include it.
Working on this made me realize that the old datreant model was not ideal and this lead to the last big refactoring introducing.
… On 13. Apr 2018, at 14:23, Richard Gowers ***@***.***> wrote:
Sure but the reason .data is separate is to keep weighty dependencies out. Is there a reason to keep cli out of the default/base package?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
It's a really simple script now. We can think about merging it into core. The whole thing is about 140 lines of code. |
Let's PR this into |
Can we use this a bit outside of code first to see how we like it and if
the api is complete and understandable?
…On Thu 2. Aug 2018 at 18:36, David Dotson ***@***.***> wrote:
Let's PR this into datreant proper. I'm less concerned about dependencies
these days, and click looks well-supported. Thanks for putting this
together @kain88-de <https://github.com/kain88-de>; I know it's been a
long time coming!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEGnVqMCeB4WnHqJaezYDm8nyPZ_gIcEks5uMyqPgaJpZM4TSZaV>
.
|
Is there a reason this can't be part of the main package?
The text was updated successfully, but these errors were encountered: