Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into core? #4

Open
richardjgowers opened this issue Apr 12, 2018 · 6 comments
Open

Merge into core? #4

richardjgowers opened this issue Apr 12, 2018 · 6 comments

Comments

@richardjgowers
Copy link

Is there a reason this can't be part of the main package?

@kain88-de
Copy link
Contributor

Because I didn’t update it yet with regard to core?

There is I believe still some stuff that doesn’t work yet. Like the tag and category selection.
We noticed that same changes to core are necessary for this library to work.

Once everything works we can think about moving it to core.

@richardjgowers
Copy link
Author

Sure but the reason .data is separate is to keep weighty dependencies out. Is there a reason to keep cli out of the default/base package?

@kain88-de
Copy link
Contributor

kain88-de commented Apr 13, 2018 via email

@kain88-de
Copy link
Contributor

It's a really simple script now. We can think about merging it into core. The whole thing is about 140 lines of code.

@dotsdl
Copy link
Member

dotsdl commented Aug 2, 2018

Let's PR this into datreant proper. I'm less concerned about dependencies these days, and click looks well-supported. Thanks for putting this together @kain88-de; I know it's been a long time coming!

@dotsdl dotsdl mentioned this issue Aug 2, 2018
@kain88-de
Copy link
Contributor

kain88-de commented Aug 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants