This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
feat: add go linters to CI #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves #240.
I have added a config file for golang-ci. The config is based on the one found here. This adds support for a common set of Go linters, along with the ability to add ignores to various checks and issues they flag through the
.golangci.ymlfile.Within the
golangci-lint.ymlfile we are adding a GitHub Action that triggers on anypull_requestto the repo. It will check out the PR's code, ensure we're using the right version of Go that we'd like, then only runs linters on new code that has been added in the PR. It does not execute against existing code (which does show failures when I run it against the entire codebase.)